Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 858F3200B13 for ; Wed, 1 Jun 2016 01:06:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 82967160A46; Tue, 31 May 2016 23:06:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB46C160A44 for ; Wed, 1 Jun 2016 01:06:24 +0200 (CEST) Received: (qmail 36419 invoked by uid 500); 31 May 2016 23:06:23 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 36408 invoked by uid 99); 31 May 2016 23:06:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 23:06:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2936E180591 for ; Tue, 31 May 2016 23:06:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5aKKBSx_-83V for ; Tue, 31 May 2016 23:06:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id DEC375F474 for ; Tue, 31 May 2016 23:06:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4VN6J7m023600; Tue, 31 May 2016 23:06:19 GMT Message-Id: <201605312306.u4VN6J7m023600@ip-10-146-233-104.ec2.internal> Date: Tue, 31 May 2016 23:06:17 +0000 From: "Tim Armstrong (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3647:_track_runtime_filter_memory_in_separate_tracker=0A?= X-Gerrit-Change-Id: I9f28f3b55b5c62e6f0f9838c5947c9446d444d20 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2721f8be58fa5fcbcb77e889426f1dff40cbcf32 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Tue, 31 May 2016 23:06:25 -0000 Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3247 to look at the new patch set (#2). Change subject: IMPALA-3647: track runtime filter memory in separate tracker ...................................................................... IMPALA-3647: track runtime filter memory in separate tracker This change breaks out runtime filter memory consumption from the query-wide tracker to improve debuggability of memory limit exceeded errors. Testing: ran exhaustive tests, ran local and cluster stress tests. Change-Id: I9f28f3b55b5c62e6f0f9838c5947c9446d444d20 --- M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-filter-bank.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h 5 files changed, 23 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/47/3247/2 -- To view, visit http://gerrit.cloudera.org:8080/3247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f28f3b55b5c62e6f0f9838c5947c9446d444d20 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho