Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4AD09200B21 for ; Fri, 27 May 2016 02:51:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 49ACA160A2B; Fri, 27 May 2016 00:51:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 914E6160A18 for ; Fri, 27 May 2016 02:51:10 +0200 (CEST) Received: (qmail 59272 invoked by uid 500); 27 May 2016 00:51:09 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 59261 invoked by uid 99); 27 May 2016 00:51:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2016 00:51:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 30646C12F8 for ; Fri, 27 May 2016 00:51:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5QYoFP7hPhXd for ; Fri, 27 May 2016 00:51:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id DB0DB5F36C for ; Fri, 27 May 2016 00:51:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4R0p5if026081; Fri, 27 May 2016 00:51:05 GMT Message-Id: <201605270051.u4R0p5if026081@ip-10-146-233-104.ec2.internal> Date: Fri, 27 May 2016 00:51:05 +0000 From: "Marcel Kornacker (Code Review)" To: Youwei Wang <429222616@qq.com>, impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson , Jim Apple , Lars Volker Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2459:_Implement_next=5Fday_date/time_UDF=0A?= X-Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e X-Gerrit-ChangeURL: X-Gerrit-Commit: 20543af84380e6a54c6e620921abc3bfbe776cf4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Fri, 27 May 2016 00:51:11 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 582 > that doesn't mean you should remove all blank lines. please put them back. please respond. -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <429222616@qq.com> Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Youwei Wang <429222616@qq.com> Gerrit-HasComments: Yes