Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201605241650.u4OGocOm013512@ip-10-146-233-104.ec2.internal>
Date: Tue, 24 May 2016 16:50:38 +0000
From: "Jim Apple (Code Review)" <gerrit@cloudera.org>
To: Youwei Wang <429222616@qq.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Marcel Kornacker <marcel@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>,
        Mostafa Mokhtar <mmokhtar@cloudera.com>,
        Jim Apple <jbapple@cloudera.com>
Reply-To: jbapple@cloudera.com
Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2809:_Improve_ByteSwap_with_builtin_function_or_SSE_or_AVX2.=0A?=
In-Reply-To: <gerrit.1463366740000.I392ed5a8d5683f30f161282c228c1aedd7b648c1@gerrit.cloudera.org>
References: <gerrit.1463366740000.I392ed5a8d5683f30f161282c228c1aedd7b648c1@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0
archived-at: Tue, 24 May 2016 16:50:44 -0000

Jim Apple has posted comments on this change.

Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2.
......................................................................


Patch Set 11:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/3081/11/be/src/benchmarks/bswap-benchmark.cc
File be/src/benchmarks/bswap-benchmark.cc:

Line 49: //                           SIMD               57.73               2.18X
Why is SIMD so much slower?


Line 222:         MACRO_TEST_FBS_CASE(8, 5)
This code can be further reduced by making 8,5 to 8,8 a loop.


Line 260: FIXED_LEN_SIZE
Which values are of interest? Is 3?


Line 263: NUM_BYTES
Please explain this in the comment above.


Line 273: bit range
The bit range of what? What are we doing with that bit range? where does "1" come from in "1x8=8"?


Line 537:         MACRO_TEST_AVX2_CASE(16, 9)
Again, this can be reduced in size with a loop over the second param.


-- 
To view, visit http://gerrit.cloudera.org:8080/3081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <429222616@qq.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Youwei Wang <429222616@qq.com>
Gerrit-HasComments: Yes