Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24B52200B2B for ; Tue, 24 May 2016 03:48:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 23967160B6A; Tue, 24 May 2016 01:48:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21A66160ACC for ; Tue, 24 May 2016 03:47:28 +0200 (CEST) Received: (qmail 84902 invoked by uid 500); 24 May 2016 01:47:28 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 84840 invoked by uid 99); 24 May 2016 01:47:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2016 01:47:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B3B361A5B3C for ; Tue, 24 May 2016 01:47:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 6ZsbeBKUTf3t for ; Tue, 24 May 2016 01:47:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 8547B5FADA for ; Tue, 24 May 2016 01:47:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4O1lMVK001360; Tue, 24 May 2016 01:47:22 GMT Message-Id: <201605240147.u4O1lMVK001360@ip-10-146-233-104.ec2.internal> Date: Tue, 24 May 2016 01:47:22 +0000 From: "Internal Jenkins (Code Review)" To: Dimitris Tsirogiannis , impala-cr@cloudera.com, dev@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.6.0=5F5.8.0)_IMPALA-3143:_Fix_permission_check_when_user_belongs_to_supergroup=0A?= X-Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d X-Gerrit-ChangeURL: X-Gerrit-Commit: b102287f2b115131eed085cade9bbd1f5d350e39 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Tue, 24 May 2016 01:48:25 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup ...................................................................... IMPALA-3143: Fix permission check when user belongs to supergroup This commit fixes an issue where a permission check warning is incorrectly generated when a user that belongs to the supergroup issues a create database statement. The fix is to also check if the user belongs to the supergroup when checking for permissions and ACLs. Testing: This change was tested manually by creating an HDFS directory D that belonged to user/group A and running a CREATE DATABASE foo LOCALTION 'D' statement as a user B that belongs to the 'supergroup' group; the test verified that when the supergroup is taken into account, no permision check warning is issued. Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Reviewed-on: http://gerrit.cloudera.org:8080/3164 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/util/FsPermissionChecker.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins