Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3DEB12009F9 for ; Mon, 23 May 2016 21:48:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3CB21160A2B; Mon, 23 May 2016 19:48:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FE19160A05 for ; Mon, 23 May 2016 21:48:13 +0200 (CEST) Received: (qmail 60056 invoked by uid 500); 23 May 2016 19:48:12 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 60043 invoked by uid 99); 23 May 2016 19:48:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2016 19:48:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2E44BCC410 for ; Mon, 23 May 2016 19:48:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZI-sM0IvMyEi for ; Mon, 23 May 2016 19:48:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B96115FB73 for ; Mon, 23 May 2016 19:48:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4NJm7ol024909; Mon, 23 May 2016 19:48:07 GMT Message-Id: <201605231948.u4NJm7ol024909@ip-10-146-233-104.ec2.internal> Date: Mon, 23 May 2016 19:48:07 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht Reply-To: tbobrovytsky@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.6.0=5F5.8.0)_IMPALA-3163:_Fix_Decimal_to_Timestamp_casting=0A?= X-Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 X-Gerrit-ChangeURL: X-Gerrit-Commit: c3d18aee3927e5b8b677fc80040a1647bd7f896f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Mon, 23 May 2016 19:48:14 -0000 Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 574: * > Yeah that's what I was thinking initially, but there way this way it's a fe btw, yes, correct either mult==1 or div==1 -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes