Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AF452009F3 for ; Fri, 20 May 2016 08:45:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 997A0160A0E; Fri, 20 May 2016 06:45:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E235A1609AF for ; Fri, 20 May 2016 08:45:28 +0200 (CEST) Received: (qmail 28802 invoked by uid 500); 20 May 2016 06:45:27 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 28791 invoked by uid 99); 20 May 2016 06:45:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2016 06:45:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2218EC1D6B for ; Fri, 20 May 2016 06:45:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R98R109Rd7NV for ; Fri, 20 May 2016 06:45:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id EC5A55F250 for ; Fri, 20 May 2016 06:45:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4K6jMZH031016; Fri, 20 May 2016 06:45:22 GMT Message-Id: <201605200645.u4K6jMZH031016@ip-10-146-233-104.ec2.internal> Date: Fri, 20 May 2016 06:45:22 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.6.0=5F5.8.0)_IMPALA-3572:_FE_unit_test_coverage_report_with_Jacoco.=0A?= X-Gerrit-Change-Id: Id5e4f1b8afb91210d40622aadd3d21d7ed94c2a7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1367e171b1d720994fb849606f5f98ab2b860529 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Fri, 20 May 2016 06:45:29 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3572: FE unit test coverage report with Jacoco. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3151/1/bin/run-all-tests.sh File bin/run-all-tests.sh: Line 62: BUILD_COVERAGE=0 > Use true/false for consistency with the rest of the script. Used CODE_COVERAGE, but I don't feel super attached to the name if you really prefer something else. Also changed the option name in buildall.sh for consistency Line 65: while getopts "e:n:c:" OPTION > Why not just make it an argument without a parameter (c instead of c:) Done http://gerrit.cloudera.org:8080/#/c/3151/1/fe/pom.xml File fe/pom.xml: Line 566: ${jacoco.skip} > Is it hard to invert the condition? It seems weird to enable something by s Adds maven weirdness but definitely more user friendly. Done. -- To view, visit http://gerrit.cloudera.org:8080/3151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e4f1b8afb91210d40622aadd3d21d7ed94c2a7 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes