Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 137FA2009EE for ; Wed, 18 May 2016 23:27:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 12328160A00; Wed, 18 May 2016 21:27:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D20B1609B0 for ; Wed, 18 May 2016 23:27:26 +0200 (CEST) Received: (qmail 10852 invoked by uid 500); 18 May 2016 21:27:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 10841 invoked by uid 99); 18 May 2016 21:27:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2016 21:27:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F3C8FC9E66 for ; Wed, 18 May 2016 21:27:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YcUBgRT7uHH0 for ; Wed, 18 May 2016 21:27:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 8AB035F248 for ; Wed, 18 May 2016 21:27:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4ILRLkM032645; Wed, 18 May 2016 21:27:21 GMT Message-Id: <201605182127.u4ILRLkM032645@ip-10-146-233-104.ec2.internal> Date: Wed, 18 May 2016 21:27:21 +0000 From: "Alex Behm (Code Review)" To: Jim Apple , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3450:_LIMITs_on_UNION_nodes_are_reflected_in_planner_cardinality_estimates=0A?= X-Gerrit-Change-Id: Ic06dcb93bbb2510c0d40151302bd817ef340b825 X-Gerrit-ChangeURL: X-Gerrit-Commit: a7173320af1903a42c8b57661b5b17d2edb3fc6b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Wed, 18 May 2016 21:27:27 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3450: LIMITs on UNION nodes are reflected in planner cardinality estimates ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3127/1/testdata/workloads/functional-planner/queries/PlannerTest/limit.test File testdata/workloads/functional-planner/queries/PlannerTest/limit.test: Line 1: # limits on union nodes are reflected in cardinality estimates Prefix with IMPALA-3450 Line 2: explain select * from tpch.lineitem UNION ALL (select * from tpch.lineitem) LIMIT 1 We usually add queries without 'explain', so let's stick to that. Please move this test to union.test, and follow the standard practice of not changing the explain level. It is unfortunate, but it avoids test flakniess (for example the "hosts" number can change for various reasons non-deterministically) The test will unfortunately have to be indirect, e.g., you can test that the union + limit is moved to the build side of a join or something like that. -- To view, visit http://gerrit.cloudera.org:8080/3127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic06dcb93bbb2510c0d40151302bd817ef340b825 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes