Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 86C572009EE for ; Wed, 18 May 2016 22:59:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 85661160A00; Wed, 18 May 2016 20:59:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CDA2D1609B0 for ; Wed, 18 May 2016 22:59:40 +0200 (CEST) Received: (qmail 27282 invoked by uid 500); 18 May 2016 20:59:40 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 27271 invoked by uid 99); 18 May 2016 20:59:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2016 20:59:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6BBEF1A53E7 for ; Wed, 18 May 2016 20:59:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4AYVZ15mJ2d4 for ; Wed, 18 May 2016 20:59:37 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B3DFD5F254 for ; Wed, 18 May 2016 20:59:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4IKxaBX031822; Wed, 18 May 2016 20:59:36 GMT Message-Id: <201605182059.u4IKxaBX031822@ip-10-146-233-104.ec2.internal> Date: Wed, 18 May 2016 20:59:36 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.6.0=5F5.8.0)_IMPALA-3332:_Free_local_allocations_in_sorter.=0A?= X-Gerrit-Change-Id: I941729b4836e5dbb827d4313a0b45bc5df2fa8e1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 795e814647be469e3fa9e1ef5d069f67fe42fe73 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Wed, 18 May 2016 20:59:41 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3116/1/testdata/workloads/functional-query/queries/QueryTest/spilling.test File testdata/workloads/functional-query/queries/QueryTest/spilling.test: Line 397: set max_block_mgr_memory=4m; > Yup, most likely. So, the merger is not invoked when we are not spilling ? Nope, if we don't spill we just have a single sorted run. The merger may be invoked as part of the exchange though. -- To view, visit http://gerrit.cloudera.org:8080/3116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I941729b4836e5dbb827d4313a0b45bc5df2fa8e1 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes