Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B51F82009C5 for ; Mon, 16 May 2016 22:59:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B3D78160131; Mon, 16 May 2016 20:59:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07D1F160A16 for ; Mon, 16 May 2016 22:59:00 +0200 (CEST) Received: (qmail 39033 invoked by uid 500); 16 May 2016 20:59:00 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 39010 invoked by uid 99); 16 May 2016 20:58:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 May 2016 20:58:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7447A180547 for ; Mon, 16 May 2016 20:58:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id RLV6JcPsFuap for ; Mon, 16 May 2016 20:58:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 9B4995F60D for ; Mon, 16 May 2016 20:58:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4GKwtj8006210; Mon, 16 May 2016 20:58:55 GMT Message-Id: <201605162058.u4GKwtj8006210@ip-10-146-233-104.ec2.internal> Date: Mon, 16 May 2016 20:58:37 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3286:_prefetching_for_PartitionedAggregationNode=0A?= X-Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b X-Gerrit-ChangeURL: X-Gerrit-Commit: 8e004f8ee073400886b3d7d47f6418b0338a8998 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Mon, 16 May 2016 20:59:01 -0000 Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode ...................................................................... IMPALA-3286: prefetching for PartitionedAggregationNode This patch builds on top of the prefetching infrastructure to add prefetching to PartitionedAggregationNode. Input batches are evaluated in prefetch groups and hash table buckets are prefetched if the prefetch_mode query option is set to HT_BUCKET. We avoid some pointer indirections on the critical path by caching hash tables in a 'hash_tbls_' array. There is also a bit of cleanup to directly instantiate the templated ProcessBatch() method to remove the ProcessBatch_true() and ProcessBatch_false() hack, and also to separate out ProcessBatchNoGrouping() so that it doesn't have to have the same argument list as ProcessBatch(). TODO: once we finish the PHJ::ProcessProbeBatch() patch I will do a final pass and make sure that this is consistent. Co-author: Michael Ho Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/hash-table.cc M be/src/exec/partitioned-aggregation-node-ir.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-aggregation-node.h 5 files changed, 203 insertions(+), 109 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/70/3070/8 -- To view, visit http://gerrit.cloudera.org:8080/3070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong