Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3257200AEF for ; Sat, 14 May 2016 00:43:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C2154160A12; Fri, 13 May 2016 22:43:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1768C16099F for ; Sat, 14 May 2016 00:43:14 +0200 (CEST) Received: (qmail 15113 invoked by uid 500); 13 May 2016 22:43:14 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 15094 invoked by uid 99); 13 May 2016 22:43:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2016 22:43:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A8B42C0218 for ; Fri, 13 May 2016 22:43:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NvWoEy1z2lzA for ; Fri, 13 May 2016 22:43:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id A3E785F480 for ; Fri, 13 May 2016 22:43:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4DMhAUC002124; Fri, 13 May 2016 22:43:10 GMT Message-Id: <201605132243.u4DMhAUC002124@ip-10-146-233-104.ec2.internal> Date: Fri, 13 May 2016 22:43:10 +0000 From: "Huaisi Xu (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: hxu@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3499:_Frontend_cannot_deserialize_catalog-update_topic_more_than_2GB.=0A?= X-Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6abc1b34080d76b62d0158fcacd845f9a2a9a610 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Fri, 13 May 2016 22:43:15 -0000 Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3067/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1290: status = exec_env_->frontend()->UpdateCatalogCache(update_req, &resp); next time update_req can be large, but this is intended. since a single topic wont be larger than 2gb(guaranteed by catalogd). I only check update_req with more than 1 entries. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: Yes