Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5392E200AE2 for ; Fri, 13 May 2016 08:16:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51D52160A10; Fri, 13 May 2016 06:16:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9CA73160939 for ; Fri, 13 May 2016 08:16:03 +0200 (CEST) Received: (qmail 86083 invoked by uid 500); 13 May 2016 06:16:02 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 86059 invoked by uid 99); 13 May 2016 06:16:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2016 06:16:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 299C01A05E3 for ; Fri, 13 May 2016 06:16:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rtujVx6uT_DQ for ; Fri, 13 May 2016 06:16:00 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7CE9A5F297 for ; Fri, 13 May 2016 06:15:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4D6FvOx018648; Fri, 13 May 2016 06:15:57 GMT Message-Id: <201605130615.u4D6FvOx018648@ip-10-146-233-104.ec2.internal> Date: Fri, 13 May 2016 06:15:57 +0000 From: "Dan Hecht (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong , Mostafa Mokhtar Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Impala-3286:_Prefetching_For_Phj_Probing.=0A?= X-Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 X-Gerrit-ChangeURL: X-Gerrit-Commit: bbbac08b3308d766a3cb9c5f4f099da43b1706ef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Fri, 13 May 2016 06:16:04 -0000 Dan Hecht has posted comments on this change. Change subject: Impala-3286: Prefetching For Phj Probing. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2959/3/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 653: BufferedTupleStream* build_rows[PARTITION_FANOUT]; > For slightly tighter cache footprint. The partition objects are probably la what do you mean the are large enough to fit in a single cache line? did you measure this helping performance? seems like it should be minimal given that there are only 16 of them so they should be hot pretty quickly... -- To view, visit http://gerrit.cloudera.org:8080/2959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes