Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17EF5200AE2 for ; Fri, 13 May 2016 02:40:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 163B6160939; Fri, 13 May 2016 00:40:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5FA50160A10 for ; Fri, 13 May 2016 02:40:14 +0200 (CEST) Received: (qmail 27398 invoked by uid 500); 13 May 2016 00:40:13 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 27033 invoked by uid 99); 13 May 2016 00:40:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2016 00:40:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EB3DC180184 for ; Fri, 13 May 2016 00:40:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mPEBhINy8mhY for ; Fri, 13 May 2016 00:40:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 68B675F36D for ; Fri, 13 May 2016 00:40:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4D0e95S009780; Fri, 13 May 2016 00:40:09 GMT Message-Id: <201605130040.u4D0e95S009780@ip-10-146-233-104.ec2.internal> Date: Fri, 13 May 2016 00:40:09 +0000 From: "Michael Brown (Code Review)" To: Lars Volker , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Taras Bobrovytsky , Bharath Vissapragada Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3489:_Add_script_to_extract_breakpad_symbols_from_binaries=0A?= X-Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7ea90c4c523254e5b2fa8dde44c5ae4c455e3ec6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Fri, 13 May 2016 00:40:15 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Thanks for addressing all my comments. I think 1 got missed, but otherwise, it looks good. http://gerrit.cloudera.org:8080/#/c/2961/5/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 227: tmp_fd, tmp_file = tempfile.mkstemp(dir=out_dir, suffix='.sym') This file never gets closed. -- To view, visit http://gerrit.cloudera.org:8080/2961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes