Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0A19200B20 for ; Wed, 11 May 2016 20:12:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF5F3160A18; Wed, 11 May 2016 18:12:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2375C160A17 for ; Wed, 11 May 2016 20:12:47 +0200 (CEST) Received: (qmail 72797 invoked by uid 500); 11 May 2016 18:12:47 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 72781 invoked by uid 99); 11 May 2016 18:12:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 18:12:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6E1521A10A7 for ; Wed, 11 May 2016 18:12:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jeZJiLg87R4w for ; Wed, 11 May 2016 18:12:43 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 88B5E5F47A for ; Wed, 11 May 2016 18:12:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4BICff7031030; Wed, 11 May 2016 18:12:41 GMT Message-Id: <201605111812.u4BICff7031030@ip-10-146-233-104.ec2.internal> Date: Wed, 11 May 2016 18:12:41 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Turn_on_C++14_in_cross-compiled_code=0A?= X-Gerrit-Change-Id: If723167b2d03da7592b64a204e31e81ea868e4f2 X-Gerrit-ChangeURL: X-Gerrit-Commit: ee6b5c1b6ca6fb3a3efd550f7d5ab6ad542855ce In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Wed, 11 May 2016 18:12:49 -0000 Dan Hecht has posted comments on this change. Change subject: Turn on C++14 in cross-compiled code ...................................................................... Patch Set 2: > Some of the STL implementation details for maps and iostreams > change slightly with the new standard, which has some flow-on > effects with how unique ids are assigned and in the functions that > use those classes but it doesn't look like there are any other > changes. File size is about the same. Okay, thanks. -- To view, visit http://gerrit.cloudera.org:8080/3024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If723167b2d03da7592b64a204e31e81ea868e4f2 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No