Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201605091839.u49IdDet013551@ip-10-146-233-104.ec2.internal>
Date: Mon, 9 May 2016 18:39:13 +0000
From: "Michael Brown (Code Review)" <gerrit@cloudera.org>
To: Alex Behm <alex.behm@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
Reply-To: mikeb@cloudera.com
Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3491:_Use_unique=5Fdatabase_fixture_in_test=5Frecover=5Fpartitions.py.=0A?=
In-Reply-To: <gerrit.1462811149000.I5be5fa5d20bc6ed5b7830e0ce90201431d6aa008@gerrit.cloudera.org>
References: <gerrit.1462811149000.I5be5fa5d20bc6ed5b7830e0ce90201431d6aa008@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0
archived-at: Mon, 09 May 2016 18:39:19 -0000

Michael Brown has posted comments on this change.

Change subject: IMPALA-3491: Use unique_database fixture in test_recover_partitions.py.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3003/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

Line 48:   def __get_fs_location(self, db_name, table_name):
       :     return 'test-warehouse/%s.db/%s/' % (db_name, table_name)
Don't you need to use get_fs_path() here?


Line 79:     assert self.has_value(PART_NAME, result.data) == False
There are a lot of places in this test module that have lines like this: comparison of a Boolean expression to a Boolean literal. While fixing these up to simply assert the expression (or assert not the expression) and not compare directly against the literal would make you a good citizen, it also isn't germane to the patch. It's up to you whether you want to fix them.


-- 
To view, visit http://gerrit.cloudera.org:8080/3003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5be5fa5d20bc6ed5b7830e0ce90201431d6aa008
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes