Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9296200AF8 for ; Thu, 5 May 2016 19:49:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B7C32160A03; Thu, 5 May 2016 17:49:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DD281609F3 for ; Thu, 5 May 2016 19:49:24 +0200 (CEST) Received: (qmail 99740 invoked by uid 500); 5 May 2016 17:49:24 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 99727 invoked by uid 99); 5 May 2016 17:49:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2016 17:49:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A6A4EC65A7 for ; Thu, 5 May 2016 17:49:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lnM1LwQVVgKl for ; Thu, 5 May 2016 17:49:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1DF8C5F1F0 for ; Thu, 5 May 2016 17:49:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u45HnHMc021088; Thu, 5 May 2016 17:49:17 GMT Message-Id: <201605051749.u45HnHMc021088@ip-10-146-233-104.ec2.internal> Date: Thu, 5 May 2016 17:49:17 +0000 From: "Ishaan Joshi (Code Review)" To: Casey Ching , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Michael Brown Reply-To: ishaan@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Add_Kudu_test_helpers=0A?= X-Gerrit-Change-Id: I8e5e22b38d5bd09a36238e66a69aa42d1a941de7 X-Gerrit-ChangeURL: X-Gerrit-Commit: db7a64bf873b6bb32984213ba70cfd0e6c79f0ce In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Thu, 05 May 2016 17:49:25 -0000 Ishaan Joshi has posted comments on this change. Change subject: Add Kudu test helpers ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/2855/9/tests/conftest.py File tests/conftest.py: Line 264: """Provides a new DB-API compliant connection to Impala as a pytest fixture. The Curious - does this mean, in the future, that parallel tests will use the same connection, but initialise their own cursors? AFAIK, as of a few months ago, one could not initialize multiple cursors from one connection, as it wasn't thread safe. Line 267: - get_db_name(): The name of the database to connect to. Why not just stub this in the base test class, and return None by default? Line 323: cur.execute("DROP DATABASE IF EXISTS %s CASCADE" % db_name) Nit: Maybe start using .format everywhere for consistency. -- To view, visit http://gerrit.cloudera.org:8080/2855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5e22b38d5bd09a36238e66a69aa42d1a941de7 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Ishaan Joshi Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes