Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DECBA200AE3 for ; Wed, 4 May 2016 06:53:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DD1B31609F8; Wed, 4 May 2016 06:53:30 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 333501609F7 for ; Wed, 4 May 2016 06:53:30 +0200 (CEST) Received: (qmail 87195 invoked by uid 500); 4 May 2016 04:53:29 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 87183 invoked by uid 99); 4 May 2016 04:53:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 May 2016 04:53:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C5A3BC0595 for ; Wed, 4 May 2016 04:53:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id za7rJxjD4459 for ; Wed, 4 May 2016 04:53:26 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 97E975F3A0 for ; Wed, 4 May 2016 04:53:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u444rPJL022806; Wed, 4 May 2016 04:53:25 GMT Message-Id: <201605040453.u444rPJL022806@ip-10-146-233-104.ec2.internal> Date: Wed, 4 May 2016 04:53:11 +0000 From: "Tim Armstrong (Code Review)" To: Skye Wanderman-Milne , Dan Hecht , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Enable_BOOST=5FNO=5FEXCEPTIONS_for_codegened_code=0A?= X-Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 X-Gerrit-ChangeURL: X-Gerrit-Commit: 531138899ffcc8cb775c6558b382879af6ed5ace In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Wed, 04 May 2016 04:53:31 -0000 Hello Internal Jenkins, Skye Wanderman-Milne, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2909 to look at the new patch set (#7). Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code ...................................................................... Enable BOOST_NO_EXCEPTIONS for codegened code BOOST_NO_EXCEPTIONS lets us provide an handler for errors instead of having boost throw exceptions. This lets us crash the process in a slightly nicer way and also greatly reduces the number of static exception objects littering the cross-compiled IR module, which helps with codegen time. Also turn on colour diagnostics for cross-compiled clang (it's already enabled for ASAN clang). Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 --- M be/CMakeLists.txt M be/src/codegen/llvm-codegen.cc 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/09/2909/7 -- To view, visit http://gerrit.cloudera.org:8080/2909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-Reviewer: Tim Armstrong