Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 485862009D9 for ; Mon, 2 May 2016 23:52:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 46E671609B0; Mon, 2 May 2016 23:52:29 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 908CF1602C5 for ; Mon, 2 May 2016 23:52:28 +0200 (CEST) Received: (qmail 69458 invoked by uid 500); 2 May 2016 21:52:27 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 69447 invoked by uid 99); 2 May 2016 21:52:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 21:52:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1A3AA1A02D1 for ; Mon, 2 May 2016 21:52:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 24emTWvmsfzG for ; Mon, 2 May 2016 21:52:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 45C0A5F2F0 for ; Mon, 2 May 2016 21:52:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u42LqMuQ018432; Mon, 2 May 2016 21:52:22 GMT Message-Id: <201605022152.u42LqMuQ018432@ip-10-146-233-104.ec2.internal> Date: Mon, 2 May 2016 21:52:20 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , Dan Hecht , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Strip_global_constructors_and_destructors_from_codegen_module=0A?= X-Gerrit-Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7c1ccf02030b5003aac4048607fa3c9fb6900f81 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Mon, 02 May 2016 21:52:29 -0000 Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2910 to look at the new patch set (#4). Change subject: Strip global constructors and destructors from codegen module ...................................................................... Strip global constructors and destructors from codegen module They are never executed, but cannot be eliminated as dead code since we could explicitly invoke them with ExecutionEngine::runStaticConstructorsDestructors() Removing them saves codegen time since we don't optimise or generate machine code for them. It also allows us to remove the custom memory manager hack for resolving dso_handle. I benchmarked the improvement with "select count(*) from tpch_parquet.lineitem" as an example of a simple query with codegen. Before the change, each fragment took ~300ms to codegen. After this change, each fragment took ~130ms to codegen. So this patch removes ~170ms of codegen overhead that was spent optimising and compiling this unexecuted code. Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6 --- M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h D be/src/codegen/mcjit-mem-mgr.h 3 files changed, 16 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/10/2910/4 -- To view, visit http://gerrit.cloudera.org:8080/2910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong