impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3633: cancel fragment if coordinator is gone
Date Fri, 27 May 2016 17:22:28 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3238

Change subject: IMPALA-3633: cancel fragment if coordinator is gone
......................................................................

IMPALA-3633: cancel fragment if coordinator is gone

The bug is that return_val.status is an optional field, so setting
the status without __isset is equivalent to Status::OK(). This
meant that fragment did not get notified when reporting status
if the coordinator had gone away. This means that is a cancel
RPC was lost, we could be left with zombie fragments with no
coordinator that kept on running until completion.

Change-Id: I62ab6f4df7c0ee60c6aa6291513f9f0cbfac3fe7
---
M be/src/service/impala-server.cc
1 file changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/38/3238/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62ab6f4df7c0ee60c6aa6291513f9f0cbfac3fe7
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message