impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Fix warnings from clang
Date Fri, 13 May 2016 19:40:57 GMT
Casey Ching has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3062

Change subject: Kudu: Fix warnings from clang
......................................................................

Kudu: Fix warnings from clang

Changes:
1) Several places in the tests didn't check return statuses.
   KUDU_ASSERT_OK can only be used in functions that return void,
   KUDU_CHECK_OK is used otherwise.
2) The forward declared "class ColumnType" should have actually been a
   struct.

Now there aren't any more Kudu related warnings from clang.

Change-Id: Id3e2f5ec9925c3cf81c7f4048decc6a5f97eee66
---
M be/src/exec/kudu-scan-node-test.cc
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-testutil.h
M be/src/exec/kudu-util.h
4 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/62/3062/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3e2f5ec9925c3cf81c7f4048decc6a5f97eee66
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>

Mime
View raw message