impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3535: Ignore invalid per-pool default query options
Date Fri, 13 May 2016 00:49:56 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3056

Change subject: IMPALA-3535: Ignore invalid per-pool default query options
......................................................................

IMPALA-3535: Ignore invalid per-pool default query options

In 2.5 we added the ability to set per-pool default query
options. A string of key-value pairs can be specified with a
pool configuration. However, if any options fail to parse,
then all the options are ignored. We want that behavior (and
returning an error) when parsing the process-wide default
query options on startup and when parsing the options sent
from a client (e.g. in beeswax server) because an error can
be returned immediately for the triggering action at that
time (i.e. starting the impalad or submitting a query with
the options set). This behavior is bad for the pool default
query options because (a) the configuration is set by the
administrator and there's nothing we can do until a query is
submitted and (b) one invalid option shouldn't mean that
other valid options aren't set.

Change-Id: If04733b775963091b0314c65286df126fd812358
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-server.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M fe/src/test/java/com/cloudera/impala/util/TestRequestPoolService.java
M fe/src/test/resources/llama-site-test2.xml
M testdata/workloads/functional-query/queries/QueryTest/set.test
A tests/query_test/test_query_opts.py
8 files changed, 92 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/56/3056/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If04733b775963091b0314c65286df126fd812358
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message