impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Robinson <he...@apache.org>
Subject Re: IMPALA-3223
Date Wed, 25 May 2016 22:30:44 GMT
I thought the long-term goal was to remove any heavyweight dependencies
that are checked into the repository. It's not the existence of thirdparty/
that's the problem there, it's what we were keeping in it.

Mustache and Squeasel change very infrequently, and are only a few K in
total. Do you think we should remove thirdparty/ for other reasons?

On 25 May 2016 at 14:20, Michael Ho <kwho@cloudera.com> wrote:

> The long term goal is to remove thirdparty. I thought we discussed about
> it.
>
> On Wed, May 25, 2016 at 2:13 PM, Henry Robinson <henry@cloudera.com>
> wrote:
>
>> (Sorry, not near Gerrit) why not keep them in thirdparty/? That makes
>> their provenance clear.
>>
>> Sent from my iPhone
>>
>> > On May 25, 2016, at 2:06 PM, Dan Hecht (Code Review) <
>> gerrit@cloudera.org> wrote:
>> >
>> > Dan Hecht has posted comments on this change.
>> >
>> > Change subject: IMPALA-3223: Move squeasel and mustache to the util
>> directory
>> > ......................................................................
>> >
>> >
>> > Patch Set 1: Code-Review+2
>> >
>> > Okay.
>> >
>> > --
>> > To view, visit http://gerrit.cloudera.org:8080/3206
>> > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>> >
>> > Gerrit-MessageType: comment
>> > Gerrit-Change-Id: I782e493bc28086a1587274b3c474ea6b6f201855
>> > Gerrit-PatchSet: 1
>> > Gerrit-Project: Impala
>> > Gerrit-Branch: cdh5-trunk
>> > Gerrit-Owner: Michael Ho <kwho@cloudera.com>
>> > Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
>> > Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
>> > Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
>> > Gerrit-HasComments: No
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "impala-cr" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to impala-cr+unsubscribe@cloudera.com.
>> > For more options, visit
>> https://groups.google.com/a/cloudera.com/d/optout.
>>
>
>
>
> --
> Thanks,
> Michael
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message