impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-2336: Ignore trailing comments in non-interactive mode
Date Fri, 27 May 2016 06:18:54 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3169/3/shell/impala_shell.py
File shell/impala_shell.py:

Line 1178:   # -- comment2
> So the handling of the cases above is inconsistent right? Usually it's best
- Digging into it, this happens because of an edge case in sanitise_input(), where we rstrip(';').
For the case you mentioned (;\n;), this returns an empty string and hence is not passed to
the impalad. If it has a comment, its non-empty and hence its sent to the impalad which returns
an error. 

- Please let me know if you want that fix to be included as a part of this patch or if it
can be dealt separately. Fwiw, this issue happens even without this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/3169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message