impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3092: Set default value to NULL in AvroSchemaConverter
Date Fri, 27 May 2016 02:28:23 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3092: Set default value to NULL in AvroSchemaConverter
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3219/5//COMMIT_MSG
Commit Message:

Line 10: become unqueriable.
> I think this double negative can reflect what happened before..
Just rephrase to:

This change ensures that Avro tables created without column definitions remain queryable if
columns are added via ALTER TABLE. The bug was that when synthesizing an Avro schema from
the column definitions we used to not add default values.


-- 
To view, visit http://gerrit.cloudera.org:8080/3219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib86e9ba1f4329b285ae14ee299365f7291a7410e
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message