impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-2336: Ignore trailing comments in non-interactive mode
Date Fri, 27 May 2016 02:06:59 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3169/4/shell/impala_shell.py
File shell/impala_shell.py:

Line 1172:   # input at query boundaries and associates the query only with preceeding comments
preceding (single e)


Line 1182:   # and throws an exception. We figure out such trailing comment (without SQL)
and remove
We figure out ... ->

We identify such trailing comments and ignore them (do not send them to Impala).


-- 
To view, visit http://gerrit.cloudera.org:8080/3169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message