impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-2336: Ignore trailing comments in non-interactive mode
Date Fri, 27 May 2016 01:52:17 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3169/3/shell/impala_shell.py
File shell/impala_shell.py:

Line 1172:   # input at query boundaries and associates the query with the comments that written
only
> associates the query only with preceding comments (following comments are a
Done


Line 1174:   # consider the following input,
> input: (colon instead of comma)
Done


Line 1178:   # -- comment2
> Hmm this seems like a strange thing to do. If this is allowed, I'd think
-- comment
;
-- comment
;
-- comment

This doesn't work. All this change does is it converts the above to the following (remove
trailing --comment).

-- comment
;
-- comment
;

The above case is invalid and raises and error.

;
;

This case used to work even before this patch and it doesn't qualify the condition introduced
in this patch.


http://gerrit.cloudera.org:8080/#/c/3169/3/tests/shell/test_file_comments.sql
File tests/shell/test_file_comments.sql:

Line 17: -- comment within-comment
> remove
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message