impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3092: Set default value to NULL in AvroSchemaConverter
Date Fri, 27 May 2016 00:36:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3092: Set default value to NULL in AvroSchemaConverter
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3219/3/testdata/avro_schema_resolution/create_table.sql
File testdata/avro_schema_resolution/create_table.sql:

Line 191: -- IMPALA-3092, create a table with extra column(added by ALTER TABLE ADD COLUMN)
with
let's move the table creation to the .test file so the tables get created through Impala


Line 201: bool_col boolean,
let's also add a TIMESTAMP and a DECIMAL column


http://gerrit.cloudera.org:8080/#/c/3219/3/testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
File testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test:

Line 74: # IMPALA-3092
include a brief description of what behavior this test is asserting


Line 81: 'eeeeeeee','f',NULL,NULL,NULL,NULL,NULL,'NULL'
missing ==== at end


-- 
To view, visit http://gerrit.cloudera.org:8080/3219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib86e9ba1f4329b285ae14ee299365f7291a7410e
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message