impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3092: Set default value to NULL in AvroSchemaConverter
Date Thu, 26 May 2016 22:06:54 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3092: Set default value to NULL in AvroSchemaConverter
......................................................................


Patch Set 3:

I ran test locally. I am kicking exhaustive run for this.

But. I ran an exhaustive test on the code with my change, but without my test. and it passed.
so unless my test break anything or my test failed, the new test should pass

-- 
To view, visit http://gerrit.cloudera.org:8080/3219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib86e9ba1f4329b285ae14ee299365f7291a7410e
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message