impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3369: Add ALTER TABLE SET COLUMN STATS statement.
Date Wed, 25 May 2016 16:32:45 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3369: Add ALTER TABLE SET COLUMN STATS statement.
......................................................................


Patch Set 6: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3189/6/fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetColumnStats.java
File fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetColumnStats.java:

Line 20: org.kududb.client.shaded.com.google.common.base.Preconditions
??


http://gerrit.cloudera.org:8080/#/c/3189/6/fe/src/main/java/com/cloudera/impala/catalog/ColumnStats.java
File fe/src/main/java/com/cloudera/impala/catalog/ColumnStats.java:

Line 58: private StatsKey(String name) {
       :       name_ = name;
       :     }
single line


Line 262: Object
Float and Long are both subclasses of Number. Maybe use that instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/3189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45cd8aa7241ea962788ba9ca7d0bbfd864c4304f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message