impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
Date Tue, 24 May 2016 23:53:35 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3201/3/source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch
File source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch:

Line 62: str.assign
> what's the actual type for StrType? why is this type templated?
std::string generally. I believe there's some support in Thrift to drop-in alternative string
types that have the same interface as std::string. Facebook had an fbstring class that may
be the motivation for this.


-- 
To view, visit http://gerrit.cloudera.org:8080/3201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58bdc899e604bde2f5b2d5360f79537ce25715ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message