impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
Date Tue, 24 May 2016 21:29:08 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
......................................................................


Patch Set 3:

Did you look into whether it's possible to do the same thing by subclassing TBinaryProtocolT
with a new implementation of readStringBody() (i.e. putting the diff into Impala?). The more
patches we accrue, the harder an upgrade of Thrift becomes.

-- 
To view, visit http://gerrit.cloudera.org:8080/3201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58bdc899e604bde2f5b2d5360f79537ce25715ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message