impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
Date Tue, 24 May 2016 21:26:19 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3282: TBinaryProtocol buffers consume unbounded memory
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3201/3/source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch
File source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch:

Line 62: str.assign
what's the actual type for StrType? why is this type templated?


Line 66: +  str.resize((uint32_t)size);
> The previous version of the code also threw bad_alloc() (explicitly, and st
We wrap our use of thrift in try/catch, and convert to error status at that level.


-- 
To view, visit http://gerrit.cloudera.org:8080/3201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58bdc899e604bde2f5b2d5360f79537ce25715ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message