impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Date Tue, 24 May 2016 18:02:44 GMT
Hello Internal Jenkins, Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3160

to look at the new patch set (#3).

Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................

Revert "Revert "Add Kudu test helpers""

This reverts commit f8dd5413b65d30646c3745dfc738ed812d50a51f and
effectively re-adds commit 9248dcb70478b8f93f022893776a0960f45fdc28. The
difference between this patch and its original is that I fixed the
changes introduced in infra/python/bootstrap_virtualenv.py to be
python2.4-compatible:

- removed the use of str.format(), preferring a str.join() pattern
- removed the call of the exit() builtin to prefer sys.exit()

The only testing I did for this patch was to ensure
CDH Impala-packaging-on-demand works.

Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
---
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
A bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
A infra/python/deps/Cython-0.23.4.tar.gz
A infra/python/deps/kudu-python-0.1.1.tar.gz
A infra/python/deps/linecache2-1.0.0-py2.py3-none-any.whl
A infra/python/deps/numpy-1.10.4.tar.gz
M infra/python/deps/requirements.txt
A infra/python/deps/traceback2-1.4.0-py2.py3-none-any.whl
A infra/python/deps/unittest2-1.1.0-py2.py3-none-any.whl
M tests/common/__init__.py
M tests/conftest.py
14 files changed, 350 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/60/3160/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message