impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir
Date Tue, 24 May 2016 10:17:19 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
......................................................................


Patch Set 1:

(2 comments)

Thanks for the reviews, please see PS3.

http://gerrit.cloudera.org:8080/#/c/3171/1//COMMIT_MSG
Commit Message:

Line 12: name collisions in case of local test clusters and strangely configured installations.
> After this change, where will the mini dumps appear in our local test setup
Added a comment.


http://gerrit.cloudera.org:8080/#/c/3171/1/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 123:     self.start_cluster_with_args()
> how does this end up starting with a relative dir rather than using self.tm
Added a comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message