impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING
Date Tue, 24 May 2016 01:50:38 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3146/9/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

Line 234: os.getenv("FILESYSTEM_PREFIX")
hmm this seems to tricky again, especially given that $NAMENODE is was derived from FILESYSTEM_PREFIX.
 Was there a reason for not introducing a second path variable to use for this?


http://gerrit.cloudera.org:8080/#/c/3146/9/tests/common/skip.py
File tests/common/skip.py:

Line 47: default_fs
can this go away with this change?


-- 
To view, visit http://gerrit.cloudera.org:8080/3146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message