impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3494: Fix Thrift TMemoryBuffer overflow
Date Mon, 23 May 2016 23:26:17 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3494: Fix Thrift TMemoryBuffer overflow
......................................................................


Patch Set 5:

> > Let's not worry about patching 0.9.2 for now (I'm not sure if any
 > of our other patches are also needed), but do you happen to know if
 > it has these bugs?
 > 
 > At least my changes are not fixed in 0.9.2. not sure about others.
 > 
 > > The commit upstream for THRIFT-1248 also patched the test code. 
 > Any reason you aren't including that part of the patch?
 > 
 > I think we do not run unit test on third party libraries? in order
 > to avoid merge conflict I did this change line by line.. I did not
 > apply any diffs with git.
 > 
 > > Huaisi, when this is ready to go in, see the instructions on the
 > wiki:
 > https://wiki.cloudera.com/display/engineering/Toolchain+for+Impala
 > Please see section "Adding a new patch for an existing Version".
 > 
 > Thanks. but it can be too much effort to run test on this. I think
 > what I can do is to test it builds. I will do this.

Why is it too much effort? There is a job that you can run that does all the hard work.

http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/
Set PUBLISH_DEPENDENCIES option is set to 0
set the REPOSITORY_URL and BRANCH where your changes are.

Anyway this is the job that you would use to publish the compiled binaries to aws. So you
need to get it configured anyway.

-- 
To view, visit http://gerrit.cloudera.org:8080/3149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91086ed9d0b4f95b5532de67fe35b46b748ad16c
Gerrit-PatchSet: 5
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message