impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3501: ee tests: detect build type and support different timeouts based on the same
Date Sat, 21 May 2016 07:19:55 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3501: ee tests: detect build type and support different timeouts based
on the same
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3156/2/tests/common/environ.py
File tests/common/environ.py:

Line 44: # Try to derive the build type. Assume it's 'latest' by default.
> I was trying to avoid touching this older stuff, but I guess it's unavoidab
Renaming the new stuff would both (a) satisfy me and (b) not touch this old stuff.


Line 135:       LOG.warn('Not enough DWARF info in {0} to determine build type; choosing '
> 1. Do you mean precisely here, or all such places, e.g, L118, L146?
1. All other places, too.


-- 
To view, visit http://gerrit.cloudera.org:8080/3156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b675c04c54e36d404fd9e5a6cf085fb8d6d0e47
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message