impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1633: GetOperationStatus should set errorMessage and sqlState
Date Sat, 21 May 2016 00:28:02 GMT
Thomas Tauber-Marshall has uploaded a new patch set (#3).

Change subject: IMPALA-1633: GetOperationStatus should set errorMessage and sqlState
......................................................................

IMPALA-1633: GetOperationStatus should set errorMessage and sqlState

Currently, we never populate the errorMessage or sqlState
fields of TGetOperationStatusResp when the GetOperationStatus
HiveServer2 rpc is called. This patch checks if the query has
an error status and if so sets errorMessage and sqlState.

GetOperationStatus also now takes the QueryExecState lock since
QueryExecState::query_state_ and QueryExecState::query_status_
are supposed to be protected by it.

This also addresses IMPALA-3298: TGetOperationStatusResp missing
error message when data is expired

Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed
---
M be/src/service/impala-hs2-server.cc
M be/src/service/query-exec-state.h
M tests/hs2/hs2_test_suite.py
M tests/hs2/test_hs2.py
4 files changed, 63 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/94/3094/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message