impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3501: ee tests: detect build type and support different timeouts based on the same
Date Fri, 20 May 2016 23:08:35 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3501: ee tests: detect build type and support different timeouts based
on the same
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3156/2/tests/common/environ.py
File tests/common/environ.py:

Line 135:       LOG.warn('Not enough DWARF info in {0} to determine build type; choosing '
> What do you think about actually dying, not just warning?
1. Do you mean precisely here, or all such places, e.g, L118, L146?

2. Besides weird, unlikely cases, like opening the wrong file altogether, the L134 condition
will be true if something strip(1)s impalad.


-- 
To view, visit http://gerrit.cloudera.org:8080/3156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b675c04c54e36d404fd9e5a6cf085fb8d6d0e47
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message