impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) Use MemTracker::MemLimitExceeded() where appropriate
Date Fri, 20 May 2016 22:57:45 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: Use MemTracker::MemLimitExceeded() where appropriate
......................................................................


Use MemTracker::MemLimitExceeded() where appropriate

This is an incremental improvement towards IMPALA-3090. Where possible
we use MemTracker::MemLimitExceeded() instead of directly constructing
the Status object.

The remaining cases where we directly construct the state are related
the the BufferedBlockMgr, which will be deprecated: either they are
produced by the BufferedBlockMgr, or produced when a Pin() unexpectedly
fails. Both of these will go away anyway.

Change-Id: I77c37f86dd15ace39e28b5cc72d37bc8d4109041
Reviewed-on: http://gerrit.cloudera.org:8080/3148
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/kudu-scanner.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/collection-value-builder.h
M be/src/runtime/row-batch-serialize-test.cc
M be/src/service/fragment-mgr.cc
8 files changed, 37 insertions(+), 27 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77c37f86dd15ace39e28b5cc72d37bc8d4109041
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message