impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3450: LIMITs on plan nodes are reflected in cardinality estimates
Date Fri, 20 May 2016 21:10:25 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3450: LIMITs on plan nodes are reflected in cardinality estimates
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3127/4/fe/src/main/java/com/cloudera/impala/planner/UnnestNode.java
File fe/src/main/java/com/cloudera/impala/planner/UnnestNode.java:

Line 70:     cardinality_ = capAtLimit(cardinality_);
> Let's also fix SelectNode while we are at it. You can create a test with a 
Done


http://gerrit.cloudera.org:8080/#/c/3127/4/testdata/workloads/functional-planner/queries/PlannerTest/joins.test
File testdata/workloads/functional-planner/queries/PlannerTest/joins.test:

Line 2202: # IMPALA-3450: limits on nodes are reflected in cardinality estimates. In this
test,
> Agreed, sorry for the confusion. My own comments are somewhat inconsistent 
Done


http://gerrit.cloudera.org:8080/#/c/3127/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test
File testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test:

Line 1813: # side, rather than the probe side, of a hash join.
> hash join -> cross join
removed


-- 
To view, visit http://gerrit.cloudera.org:8080/3127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06dcb93bbb2510c0d40151302bd817ef340b825
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message