impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [hs2client-CR] Fix hs2client EXPECT_OK macro.
Date Fri, 20 May 2016 20:17:12 GMT
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3068

to look at the new patch set (#5).

Change subject: Fix hs2client EXPECT_OK macro.
......................................................................

Fix hs2client EXPECT_OK macro.

The EXPECT_OK macro used in tests references its parameters twice,
leading to duplicate execution. Fix this by updating it to store
the parameter's value to a local veriable so it is only referenced
once.

Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8
---
M src/hs2client/test-util.h
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/hs2client refs/changes/68/3068/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8
Gerrit-PatchSet: 5
Gerrit-Project: hs2client
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wes McKinney <wes@cloudera.com>

Mime
View raw message