impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [hs2client-CR] Fix hs2client EXPECT_OK macro.
Date Fri, 20 May 2016 18:49:21 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: Fix hs2client EXPECT_OK macro.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h
File src/hs2client/test-util.h:

Line 31: status
> MJ, this IS what I had in mind, and I also share your concern about the lin
Your suggestion doesn't quite work for a few reasons:

- Token pasting and macro expansion don't work together easily. I was able to find a workaround,
but its awkward. http://stackoverflow.com/questions/1597007/creating-c-macro-with-and-line-token-concatenation-with-positioning-macr

- __FILE__ expands as a string literal, which prevents it from being pasted into a variable
name due to the quotation marks. I couldn't find a solution for this, maybe you know of one,
though I think just using __LINE__ is probably fairly good for uniqueness.

I submitted the best thing that I could come up with.


-- 
To view, visit http://gerrit.cloudera.org:8080/3068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8
Gerrit-PatchSet: 2
Gerrit-Project: hs2client
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wes McKinney <wes@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message