impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) Use MemTracker::MemLimitExceeded() where appropriate
Date Fri, 20 May 2016 17:49:47 GMT
Tim Armstrong has posted comments on this change.

Change subject: Use MemTracker::MemLimitExceeded() where appropriate
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3148/1/be/src/exec/nested-loop-join-node.cc
File be/src/exec/nested-loop-join-node.cc:

Line 85: 1)
> It'll be clearer if it's Bitmap::MemUsage(1). May be worth factoring it out
Done


http://gerrit.cloudera.org:8080/#/c/3148/1/be/src/service/fragment-mgr.cc
File be/src/service/fragment-mgr.cc:

Line 48: Substitute("Instance $0 of plan fragment $1 of query $2 could not "
       :             "start because the backend Impala daemon is over its memory limit",
       :             PrintId(exec_params.fragment_instance_ctx.fragment_instance_id),
       :             exec_params.fragment.display_name,
       :             PrintId(exec_params.fragment_instance_ctx.query_ctx.query_id))
> nit: it's slightly easier to read if this is factored out as a variable.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77c37f86dd15ace39e28b5cc72d37bc8d4109041
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message