impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3572: FE unit test coverage report with Jacoco.
Date Fri, 20 May 2016 06:45:22 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3572: FE unit test coverage report with Jacoco.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3151/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:

Line 62: BUILD_COVERAGE=0
> Use true/false for consistency with the rest of the script.
Used CODE_COVERAGE, but I don't feel super attached to the name if you really prefer something
else.

Also changed the option name in buildall.sh for consistency


Line 65: while getopts "e:n:c:" OPTION
> Why not just make it an argument without a parameter (c instead of c:)
Done


http://gerrit.cloudera.org:8080/#/c/3151/1/fe/pom.xml
File fe/pom.xml:

Line 566:           <skip>${jacoco.skip}</skip>
> Is it hard to invert the condition? It seems weird to enable something by s
Adds maven weirdness but definitely more user friendly. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/3151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e4f1b8afb91210d40622aadd3d21d7ed94c2a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message