impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3314/IMPALA-3513: Fix querying tables/partitions altered to Avro format
Date Fri, 20 May 2016 04:40:29 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3314/IMPALA-3513: Fix querying tables/partitions altered to Avro format
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3136/1/be/src/exec/hdfs-avro-scanner.cc
File be/src/exec/hdfs-avro-scanner.cc:

Line 63:     return Status("Missing avro schema in scan node. This could be due to stale "
> Avro schema (capitalize 'Avro' since it is a proper noun)
Oops, missed this, done.


Line 741:     return Status("Missing avro schema in scan node. This could be due to stale
"
> Avro
Done


http://gerrit.cloudera.org:8080/#/c/3136/1/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java
File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java:

Line 1255:   private boolean hasParitionOfFileFormat(HdfsFileFormat fileFormat) {
> instead of going over all partitions again, let's set a flag hasAvroData_ o
Nice idea, although I don't understand the need for maintaining a Set. I made the changes
for hasAvroData_


Line 1269:     Preconditions.checkState(isSchemaLoaded_);
> If possible, let's remove the isSchemaLoaded_ flag and use a more direct pr
Done


http://gerrit.cloudera.org:8080/#/c/3136/1/testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test
File testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test:

Line 3: drop table if exists functional_avro_snap.alltypesagg_staleschema
> use unique_database fixture and a non-qualified test table name
Per my understanding of unique db fixture, it is not yet supported for .test files. Is my
understanding correct? If yes, do you want me to move this testing to the pytest rather than
doing it in a .test file?


-- 
To view, visit http://gerrit.cloudera.org:8080/3136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09262d3a7b85a2263c721f3beafd0cab2a1bdf4b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message