impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2848: Simplify creation of a new Kudu table
Date Thu, 19 May 2016 01:55:56 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-2848: Simplify creation of a new Kudu table
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2984/4/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java
File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java:

Line 233: else {
> It's best to explain why, this statement isn't really compelling :)
Well, this function seems too big for me. The entire else block has a well defined purpose
which is to analyze the format for a managed table. Imagine reading this function and instead
of going through 60 lines of code you'd see a single function call. I feel it would improve
readability of the code, but again it's a matter of personal taste.  It was merely a suggestion...


-- 
To view, visit http://gerrit.cloudera.org:8080/2984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5714941a81bad7a410c850e4037637cffaf8ab
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message