impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting
Date Wed, 18 May 2016 21:42:59 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3163: Fix Decimal to Timestamp casting
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

Dan, can you take a final look?

http://gerrit.cloudera.org:8080/#/c/2791/8/be/src/exprs/decimal-operators-ir.cc
File be/src/exprs/decimal-operators-ir.cc:

Line 567:       int64_t mult = DecimalUtil::GetScaleMultiplier<int64_t>(max(0, 9 - scale));
Use a constant int for the '9' and comment that timestamp has nanosecond precision (i.e. 9
fractional digits)


-- 
To view, visit http://gerrit.cloudera.org:8080/2791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message