impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [hs2client-CR] Fix hs2client EXPECT_OK macro.
Date Tue, 17 May 2016 18:21:51 GMT
Jim Apple has posted comments on this change.

Change subject: Fix hs2client EXPECT_OK macro.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h
File src/hs2client/test-util.h:

Line 31: status
> Defining them as macros is more consistent with the gtest EXPECT_TRUE/FALSE
What about

    #define EXPECT_OK(stmt) expect_ok_fn(__LINE__, stmt)

    void expect_ok_fn(int line_number, ...

or maybe keeping it as a macro but making the Status variable more likely to be uniquely named:

    Status status ## __FILE__ ## __LINE__ = (stmt);


-- 
To view, visit http://gerrit.cloudera.org:8080/3068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8
Gerrit-PatchSet: 2
Gerrit-Project: hs2client
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wes McKinney <wes@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message