impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_hbase_metadata.py.
Date Tue, 17 May 2016 05:22:47 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3491: Use unique_database fixture in test_hbase_metadata.py.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3074/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3491: Use unique_database fixture in test_hbase_metadata.py.
> Should you write a different commit summary considering test_hbase_metadata
Done


http://gerrit.cloudera.org:8080/#/c/3074/1/tests/metadata/test_compute_stats.py
File tests/metadata/test_compute_stats.py:

Line 45
> Was this intentional? I can't find any end-to-end test that uses compute-st
Not intentional. Restored. Re-ran tests. All green.


Line 123:     cls.TestMatrix.add_constraint(\
> Nit: backslash not needed.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8b84e30948c3c98166e08cae2666574777730c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message