impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants
Date Tue, 17 May 2016 02:02:07 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3168: replace HashTable parameters with constants
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3088/5/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:

Line 473:   /// value 'replacement'.
Would be good to comment on the return value as this is pretty far away from ReplaceCallSites()
declaration.


http://gerrit.cloudera.org:8080/#/c/3088/5/be/src/exec/hash-table.cc
File be/src/exec/hash-table.cc:

Line 1160: int num_build_tuples,
Is this used at all in this function ?


http://gerrit.cloudera.org:8080/#/c/3088/5/be/src/exec/hash-table.h
File be/src/exec/hash-table.h:

Line 828: 
extra blank line?


http://gerrit.cloudera.org:8080/#/c/3088/5/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

Line 458: stores_duplicates,
Just curious why we cannot just put true here ? I thought the existing pattern is to do true
/* stores_duplicates */, or something along that line.


-- 
To view, visit http://gerrit.cloudera.org:8080/3088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I483a19662c90ca54bc21d60fd6ba97dbed93eaef
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message